Feedback from Simplemachine

Started by Feline, 11 years ago

previous topic - next topic

0 Members and 1 Guest are viewing this topic.

Feline

*
11 years ago
Yesterday, I have received a PM from SMF Customization Team ...

A long list of smaller typos, and three, four smaller bugs they have found ..  :o
I startet to fix all these thing .. a long night....
Today I have all tested and I think, is't ok now.

Here comes .. the long list  ;D
Package-info.xml
    * Line 18: url="?action" What action is it redirecting too?
    * Line 31: Space needed before timeout and an action specified

fixed, redirect url now "$scripturl"

db_install.php
    * Line 251: spelling mistake unneccessary should be unnecessary
    * Line 264: spelling mistake depent should be dependent

fixed

remove_done.html
    * Line 6: automaticly should be automatically

fixed

install_done.html
    * Line 4: Has instead of have in "Because the installer have added"

fixed, also automaticly -> automatically

When installed
    * Blocks page, doesn't check order fields are integer.
    * Suggestion Only: On the javascript dropmenu in Admin.

fixed, same on the blockmanager (cachetime input)
Here you can now also enter "24*60" .. for peoples, they can't calculate ;)
Images for Admin dropmenu added


AdminSettings.english.php
    * Line 16: Possibly should be 'will be', instead of 'are'
    * Line 18: but it\'s show allway
      Allway? is that a word?
      Show possibly should be shown.
    * Line 56: normaly = normally and neccessary = necessary

fixed, allway -> always

blocks/user_login.english.php
    * Line 13: $txt['show_pm'] = 'Privat Messages';
      Should be "Private"

fixed

statistics.english.php
    * Line 11: Statitics should be Statistics
    * Line 16: Entrys should be Entries

fixed

AdminSettings.template.php
    * Hard-coded text string - "information" x 3 occurances

Sources/Portmx/Class/statistics_adm.php
    * Hard-coded text string - "information" x 1 occurances

fixed, also all in Sources/Portmx/Class/System/PortaMx_AdminBlocksClass.php

Sources/Portmx/Class/statistics.php
    * Hard-coded text string - line 30 "memberlist"
    * Hard-coded text string - line 45 "statistics"
    * Hard-coded text string - line 68 "online user"

fixed

Sources/Portmx/Class/download.php
    * Lines 45and 46. Variables not passed in via the array. (especially the use of single quotes)
    * Hard-coded text strings: Line 62. "Kb, Downloads:"
      Both kb and downloads probably should have their own text strings.

fixed

Also fixed "Front page" -> "Frontpage"

I have add a check for all numeric input fields..
1. The value is checked with a small javascript while entered.
2. A second check is implemeted, while processing the $_POST array.
   The value is checked on exist and numeric.
   If it's not numeric (then it's empty), it's handled as empty and a default value is used.
   This is necessary, while "0" is often a legal value.
   The name of the checked $_POST value is defined in the OOP Admin module itself (hidden input "check_num_vars").

I have changed the download block, so his can use the content caching.
This reduces the load, while no database query is necessary.
If a file downloaded, the cache is reset to update the download counter.


Fel
Many are stubborn in relation to the way, but less in relation to the target.

Feline

*
#1
11 years ago
Yes ... I work hard on this project to push PortaMx  ;)
And I think, I'm on the right way ...

Fel
Many are stubborn in relation to the way, but less in relation to the target.

Guest

*
#2
11 years ago
Really serious stuff  ;D ;D

Guest

*
#3
11 years ago
Will these serious errors put back the date for first final ;D ;D ;D ;D

* Shouts

Feline
a year ago
Today we update our Forum to the Version 1.45
Feline
a year ago
Today we update our Forum to Version 1.4
This release is full compatible with the EU GDPR
Feline
a year ago
Update for PortaMx 1.54 ecl released.
With this updates the Portal works with PHP 7.x and SMF 2.0.15
Feline
a year ago
PortaMx Forum 1.3
released !

*
Feline
a year ago
Today we switched to PHP 7.2 and activate Opcode caching.
Fast .. Very fast *
Feline
2 years ago
Today we upgrade our old SMF 2.0 Forum to PortaMx Forum *

* Calendar

Su
Mo
Tu
We
Th
Fr
Sa
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31