2nd Feedback from Simple Machine

Started by Feline, 10 years ago

previous topic - next topic

0 Members and 1 Guest are viewing this topic.

Feline

*
10 years ago
Yesterday I have get the next Feedback from SMF Customization Team.
A new long list of misspellings and other small stuff ..  ???

Here now the list and my answer ...

Lines 105-132: Modifies SMF's copyright function in Subs which is NOT allowed.
As we wrote in a PM..
The PortaMx corp. is not willing to change that, until SMF add a "usercopyright" call in the copyright function.
Example (used by PortaMx);

Code Select
function theme_copyright($get_it = false)
{
.....
// If it's in the copyright, and we are outputting it... it's been found.
if (isset($modSettings['copyright_key']) && sha1($modSettings['copyright_key'] . 'banjo') == ....

user_copyright();   // call the user copyright

echo '
</span>';
}

// Any Mod Author can add his copyright here
function user_copyright()
{
echo '
<br />', PortaMx_copyright()';
}


Also, SMF have to remove the "line-height: 0" in /css/index.css
Code Select
#footerarea ul li.copywrite
{
display: block;
line-height: 0; /* <--- remove that */
font-size: small;
padding: 1em;
}


db_install.php
Line 250: "wich" should be "which", "a Admin" should be "an Admin"
Line 251: "pesent" should be "present", "reduced" in this context should be "reduces"
Line 252: "if is visible" should be "if it is visible"
Line 256: "exist" in this context should be "existing"

fixed

Line 274: " they are provided soon." doesn't make sense as part of that sentence?
We see nothing in this, what's not correct

db_remove.php
Line 11: Unneeded/unreferences globals. Since you don't use these they can be removed.
global $db_name, $db_prefix;

fixed

install_done.html and remove_done.html
Suggestion only: Use css to align center rather than <center> tags eg
<div style="margin:0 auto; text-align:center"></div>

fixed

Themes\default\languages\PortaMx\Admin.english.php
Line 34: "have" should be "has" in this context

fixed

Themes\default\languages\PortaMx\AdminBlocks.english.php
Line 73: "Typ" should be "Type"
Line 90: (IE needs tree clicks!) Should tree be three?
Line 89-90-91. I believe Strg Key is called Ctrl (Control) key on English Keyboards

fixed

Themes\default\languages\PortaMx\AdminBlocks.english.php
vs
Themes\default\languages\PortaMx\AdminSettings.english.php
AdminBlocks.english.php Line 115    'pm' => 'Priv. Messages',
vs
AdminSettings.english.php Line 36    'pm' => 'My Messages'

fixed

Themes\default\languages\PortaMx\Blocks\download.english.php
Line 13: "they" should probably be "that"

fixed

Themes\default\PortaMx\AdminBlocks.template.php
Line 15: I wouldn't normally mention it, but in case you are a perfectionist like me
<form  accept-charset="
Two spaces after <form
Line 19: Hard-coded text string PortaMx.
Whilst this is unlikely to change, it would be preferrable if it was in a language file.

fixed

Themes\default\PortaMx\AdminSettings.template.php
Line 18: Hard-coded text string PortaMx.
Whilst this is unlikely to change, it would be preferrable if it was in a language file.

fixed

Themes\default\PortaMx\Mainindex.template.php
Just a note about $forum_version. Some people modify this in index.php to hide the version number

fixed

Themes\default\PortaMx\SysCss\download.css
Suggestion: I wouldn't normally mention it and wouldn't matter for approval purposes.
But the last css item does follow your tab styling
.dlcomment
{
padding-left: 0px;
font-family: Tahoma;
line-height: 1.1em;
}

fixed

\Sources\PortaMx\LoadData.php
Line 59: Is INNER JOIN for the boards table necessary in that query.
             INNER JOIN {db_prefix}boards AS b ON (b.id_board = m.id_board)

fixed

Also, suggestion:
// get all smf boards
function PortaMx_getsmfBoards()
....
Couldn't getBoardTree in Sources/Subs-Boards.php be used here instead?

No .. We need only the board ID and the name for admin parts

editor_uploads/folders:
Blank folders will not always be created properly on install.  On some hosts they may require at least one file in them to be created (or created with the proper chmod permissions)
Also for security reasons you might want to include an index.php file to prevent these directories being viewed directly.

fixed, index.php inside all folder

General Point. Only ever specify columns that are needed.
Only use * unless really needed (although it may be). Code: [Select]

   $request = $smcFunc['db_query']('', '
         SELECT * FROM {db_prefix}portamx_blocks
         ORDER BY side ASC, pos ASC',
      array()
   );

The admin part need all colums, so the query is absulutly correct

readme.bbc
Finally in licence part of your the readme, "ISING" should be "ARISING"

fixed

When Installed
In Wap. your left sidebar, breaks the validity of wap.
(Install go into a topic, then view the source, and you will see what I mean)
eg http://localhost/b/index.php?topic=1.0;wap
If your mod doesn't support wap/imode/wap2, then it shouldn't modify those in the meantime.

fixed, on wap, wap2, imode the Portal is invisible

On every page I'm getting
: Undefined index: global_character_set
File: C:/xampplite/htdocs/b/Sources/PortaMx/PortaMx.php
 
fixed

In Block Manager when selecting block-type 'Download'
when I then selected cssfile 'sample'
I was redirected and got
Wrong value type sent to the database. Integer expected.
Function: PortaMx_AdminBlocks
File: C:/xampplite/htdocs/b/Sources/PortaMx/AdminBlocks.php

We can't reproduce this error

Fel

Many are stubborn in relation to the way, but less in relation to the target.

Feline

*
#1
10 years ago
Just I have upload a release to SMF without the copyright violation.
I hope, that I becomes now  SMF's approve quickly ...

Fel
Many are stubborn in relation to the way, but less in relation to the target.

Powerbob

*
#2
10 years ago
Do you need to have it registered as a Mod? I think a lot of the opposition is from members of the TP team. They still haven't understood that there are no edits to the themes for PortaMx.  8)
*
My test Site;http://pplb.net/smf21/index.php
It's nice to be nice :)

Feline

*
#3
10 years ago
I have it registred as a mod .. but I have placed the PortaMx copyright in the SMF copyright function. That was not legal to the SMF license police.
No I have make that in a other place and hope the approve comes quick  ::)

Fel
Many are stubborn in relation to the way, but less in relation to the target.

Feline

*
#4
10 years ago
Thanks  .. just I see the PortaMx is approved  :)
A good start in the future .. I think.

Fel
Many are stubborn in relation to the way, but less in relation to the target.

Powerbob

*
#5
10 years ago
Just took a look and YEP you are approved  8)
*
My test Site;http://pplb.net/smf21/index.php
It's nice to be nice :)

* Shouts

Feline
5 months ago
Today we update our Forum to the Version 1.45
Feline
8 months ago
Today we update our Forum to Version 1.4
This release is full compatible with the EU GDPR
Feline
10 months ago
Update for PortaMx 1.54 ecl released.
With this updates the Portal works with PHP 7.x and SMF 2.0.15
Feline
10 months ago
PortaMx Forum 1.3
released !

*
Feline
a year ago
Today we switched to PHP 7.2 and activate Opcode caching.
Fast .. Very fast *
Feline
a year ago
Today we upgrade our old SMF 2.0 Forum to PortaMx Forum *

* Calendar

Su
Mo
Tu
We
Th
Fr
Sa
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28